Horton

Re: A recent message added to pg_upgade

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, smithpb2250@gmail.com, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2025-07-10T04:10:02Z
Lists: pgsql-hackers 
On Wed, Jul 9, 2025 at 5:46 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> >
>
> > I propose a few comment updates on top of your patch.
>
> This comment updates LGTM, so included in v3.
>

What shall we do for exposed check_hook functions
check_max_slot_wal_keep_size() and
check_idle_replication_slot_timeout() in backbranch? Shall we remove
there as well or leave them to avoid the risk of breaking any
application?

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix the handling of two GUCs during upgrade.

  2. Rework how logirep launchers are stopped during pg_upgrade

  3. Prohibit max_slot_wal_keep_size to value other than -1 during upgrade.

  4. Prevent startup of logical replication launcher during pg_upgrade

  5. Migrate logical slots to the new node during an upgrade.