Horton

Re: Single transaction in the tablesync worker?

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Ajin Cherian <itsajin@gmail.com>, Petr Jelinek <petr.jelinek@enterprisedb.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-24T12:25:54Z
Lists: pgsql-hackers 
On Wed, Feb 24, 2021 at 12:47 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Fri, Feb 12, 2021 at 2:49 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> >
> > Thanks, I have pushed the fix and the latest run of 'thorntail' has passed.
>
> I got the following WARNING message from a logical replication apply worker:
>
> WARNING:  relcache reference leak: relation "pg_subscription_rel" not closed
>
> The cause of this is that GetSubscriptionRelState() doesn't close the
> relation in SUBREL_STATE_UNKNOWN case. It seems that commit ce0fdbfe9
> forgot to close it. I've attached the patch to fix this issue.
>

Thanks for the report and fix. Your patch LGTM. I'll push it tomorrow.

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix relcache reference leak introduced by ce0fdbfe97.

  2. Fix Subscription test added by commit ce0fdbfe97.

  3. Allow multiple xacts during table sync in logical replication.

  4. Logical replication support for initial data copy