Re: [Patch] Optimize dropping of relation buffers using dlist

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>

To: "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>

Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-12-24T14:07:17Z

Lists: pgsql-hackers

Attachments

v38-0001-Optimize-DropRelFileNodeBuffers-for-recovery.patch (application/octet-stream) patch v38-0001
v38-0002-Optimize-DropRelFileNodesAllBuffers-for-recovery.patch (application/octet-stream) patch v38-0002
v38-0003-Prevent-invalidating-blocks-in-smgrextend-during.patch (application/octet-stream) patch v38-0003

On Wed, Dec 23, 2020 at 6:27 PM k.jamison@fujitsu.com
<k.jamison@fujitsu.com> wrote:
>
>
> It compiles. Passes the regression tests too.
> Your feedbacks are definitely welcome.
>

Thanks, the patches look good to me now. I have slightly edited the
patches for comments, commit messages, and removed the duplicate
code/check in smgrnblocks. I have changed the order of patches (moved
Assert related patch to last because as mentioned earlier, I am not
sure if we want to commit it.). We might still have to change the scan
threshold value based on your and Tang-San's results.

-- 
With Regards,
Amit Kapila.

Commits

Fix size overflow in calculation introduced by commits d6ad34f3 and bea449c6.
- 519e4c9ee21a 14.0 landed
Optimize DropRelFileNodesAllBuffers() for recovery.
- bea449c635c0 14.0 landed
Optimize DropRelFileNodeBuffers() for recovery.
- d6ad34f3410f 14.0 landed
Cache smgrnblocks() results in recovery.
- c5315f4f4484 14.0 cited
Add a check to prevent overwriting valid data if smgrnblocks() gives a
- ffae5cc5a602 8.2.0 cited