Re: windows build slow due to windows.h includes

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2021-09-22T08:44:59Z
Lists: pgsql-hackers
On Wed, Sep 22, 2021 at 11:14 AM Noah Misch <noah@leadboat.com> wrote:
>
> On Tue, Sep 21, 2021 at 12:30:35PM -0700, Andres Freund wrote:
> > solution to windows.h being just so damn big, the delightfully named
> > WIN32_LEAN_AND_MEAN.
> >
> > This reduces the non-incremental buildtime in my 8 core windows VM from 187s to
> > 140s. Cross compiling from linux it's
> > master:
> > real  0m53.807s
> > user  22m16.930s
> > sys   2m50.264s
> > WIN32_LEAN_AND_MEAN
> > real  0m32.956s
> > user  12m17.773s
> > sys   1m52.313s
>
> +1, great win for a one-liner.
>

+1. It reduced the build time of Postgres from "Time Elapsed
00:01:57.60" to "Time Elapsed 00:01:38.11" in my Windows env. (Win 10,
MSVC 2019).

-- 
With Regards,
Amit Kapila.



Commits

  1. windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.