Horton

Re: Allow logical replication to copy tables in binary format

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, Melih Mutlu <m.melihmutlu@gmail.com>, vignesh C <vignesh21@gmail.com>, Euler Taveira <euler@eulerto.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-23T05:48:19Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow logical replication to copy tables in binary format.

  2. Common function for percent placeholder replacement

  3. Doc: add XML ID attributes to <sectN> and <varlistentry> tags.

  4. Re-order disable_on_error in tab-complete.

  5. Make subscription tests pass with log_error_verbosity=verbose

  6. Weaken type-OID-matching checks in array_recv and record_recv.

  7. Allow logical replication to transfer data in binary format.

On Wed, Mar 22, 2023 at 4:06 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> > The patch looks mostly good to me. However, I have one
> > question/comment as follows:
> >
> > -       <varlistentry>
> > +       <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
> >          <term><literal>binary</literal> (<type>boolean</type>)</term>
> >          <listitem>
> >
> > To allow references to the binary option, we add the varlistentry id
> > here. It looks slightly odd to me to add id for just one entry, see
> > commit 78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5 where we have
> > purposefully added ids to allow future references. Shall we add id to
> > other options as well on this page?
>
> I have analyzed same points and made patch that could be applied atop v19-0001.
> Please check 0002 patch.
>

Pushed the 0001. It may be better to start a separate thread for 0002.

-- 
With Regards,
Amit Kapila.