Horton

Re: Design of pg_stat_subscription_workers vs pgstats

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Andres Freund <andres@anarazel.de>, "David G. Johnston" <david.g.johnston@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-02-28T03:50:11Z
Lists: pgsql-hackers 
On Mon, Feb 28, 2022 at 8:59 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
>
> 2. doc/src/sgml/monitoring.sgml
>
> +        Resets statistics for a single subscription shown in the
> +        <structname>pg_stat_subscription_stats</structname> view to zero. If
> +        the argument is <literal>NULL</literal>, reset statistics for all
> +        subscriptions.
>         </para>
>
> SUGGESTED (simpler description, more similar to pg_stat_reset_replication_slot)
> Reset statistics to zero for a single subscription. If the argument is
> <literal>NULL</literal>, reset statistics for all subscriptions.
>

As discussed, it is better to keep the view name in this description
important as we have another view (pg_stat_susbcription) as well. So,
I am planning to retain the current wording.

-- 
With Regards,
Amit Kapila.

Commits

  1. Reconsider pg_stat_subscription_workers view.

  2. Add a view to show the stats of subscription workers.