Re: Observations in Parallel Append

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-01-04T03:54:41Z
Lists: pgsql-hackers
On Thu, Jan 4, 2018 at 9:06 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Jan 2, 2018 at 11:11 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> Attached, please find the patch which fixes this issue (Thanks to
>> Dilip for helping me in identifying the above case and fix).  I have
>> also modified the comment atop function
>> choose_next_subplan_for_worker() as discussed above.  The change to
>> remove unnecessary inclusion of spin.h is still in a separate patch as
>> posted above.
>
> Here's a combined patch with some cosmetic changes which I will commit
> if it looks OK to you.
>

Looks good to me.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


Commits

  1. Code review for Parallel Append.