Re: LogicalChanges* and LogicalSubxact* wait events are never reported
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-21T08:40:55Z
Lists: pgsql-hackers
On Wed, Oct 20, 2021 at 3:46 PM Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote: > > On 2021/10/20 18:17, Amit Kapila wrote: > > On Wed, Oct 20, 2021 at 10:50 AM Michael Paquier <michael@paquier.xyz> wrote: > >> > >> On Wed, Oct 20, 2021 at 02:12:20PM +0900, Masahiro Ikeda wrote: > >>> If my understanding is right, it's better to remove them since they make > >>> users confused. Please see the attached patch. I confirmed that to make > >>> check-world passes all tests. > >> > >> Yeah, I don't see the point in keeping these events around if they are > >> not used. Perhaps Amit has some plans for them, though. > >> > > > > No, there is no plan for these. As far as I remember, during > > development, we have decided to use BufFile interface and forgot to > > remove these events which were required by the previous versions of > > the patch. I'll take care of this. > > > > Thanks for the report and patch! > Thanks for your replies and for handling it! > Pushed! -- With Regards, Amit Kapila.
Commits
-
Remove unused wait events.
- 671eb8f34404 14.1 landed
- 1607cd0b6c99 15.0 landed
-
Add support for streaming to built-in logical replication.
- 464824323e57 14.0 cited