Horton

Re: parallel vacuum comments

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>
Date: 2021-12-21T13:24:03Z
Lists: pgsql-hackers

Attachments

On Tue, Dec 21, 2021 at 11:24 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Tue, Dec 21, 2021 at 2:04 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
>
> Thank you for the comment. Agreed.
>
> I've attached updated version patches. Please review them.
>

These look mostly good to me. Please find attached the slightly edited
version of the 0001 patch. I have modified comments, ran pgindent, and
modify the commit message. I'll commit this tomorrow if you are fine
with it.

-- 
With Regards,
Amit Kapila.

Commits

  1. Move parallel vacuum code to vacuumparallel.c.

  2. Move index vacuum routines to vacuum.c.

  3. Improve parallel vacuum implementation.

  4. Fix parallel amvacuumcleanup safety bug.

  5. Simplify state managed by VACUUM.