Re: Add an option to skip loading missing publication to avoid logical replication failure

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, tgl@sss.pgh.pa.us, Dilip Kumar <dilipbalaut@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-05-10T11:45:22Z
Lists: pgsql-hackers
On Tue, May 6, 2025 at 5:17 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, May 6, 2025 at 3:33 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> >
> > A clear benefit of addressing this in code is to ensure that the user sees the log message, which can be valuable for trouble-shooting—even under race conditions.
> >
>
> I don't think we can take that guarantee because if the Insert is
> concurrent or slightly before the Alter Subscription command, then
> there won't be a guarantee that users will see the skipped LOG
> message.
>

I am planning to proceed with the test-fix proposed by Vignesh [1]
early next week unless we want to discuss more on this issue.

[1] - https://www.postgresql.org/message-id/CALDaNm3TH3J8fwj%2BNcdjdN8DZCdrnmm1kzBsHBW2nkN%2Bh6up3A%40mail.gmail.com

-- 
With Regards,
Amit Kapila.



Commits

  1. Fix the race condition in the test added by 7c99dc587.