Re: Documentation: warn about two_phase when altering a subscription

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Tristen Raab <tristen.raab@highgo.ca>
Cc: pgsql-hackers@lists.postgresql.org, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Date: 2024-03-11T04:15:27Z
Lists: pgsql-hackers
On Sat, Feb 24, 2024 at 5:21 AM Tristen Raab <tristen.raab@highgo.ca> wrote:
>
> I've reviewed your patch, it applies correctly and the documentation builds without any errors. As for the content of the patch itself, I think so far it's good but would make two modifications. I like how the patch was worded originally when referring to the subscription, stating these parameters were 'in' the subscription rather than 'by' it. So I'd propose changing
>
> > parameters specified by the subscription. When creating the slot, ensure
>
> to
>
> > parameters specified in the subscription. When creating the slot, ensure
>

This suggestion makes sense, so I updated the patch for this and committed.

-- 
With Regards,
Amit Kapila.



Commits

  1. Doc: Warn about two_phase when altering a subscription's slot name.