Re: Build-farm - intermittent error in 031_column_list.pl

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-05-24T12:49:45Z
Lists: pgsql-hackers

Attachments

On Sat, May 21, 2022 at 9:03 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, May 20, 2022 at 4:01 PM Tomas Vondra
> <tomas.vondra@enterprisedb.com> wrote:
>
> > Also, we'd probably have to ignore RelationSyncEntry for a while, which
> > seems quite expensive.
> >
>
> Yet another option could be that we continue using a historic snapshot
> but ignore publications that are not found for the purpose of
> computing RelSyncEntry attributes. We won't mark such an entry as
> valid till all the publications are loaded without anything missing. I
> think such cases in practice won't be enough to matter. This means we
> won't publish operations on tables corresponding to that publication
> till we found such a publication and that seems okay.
>

Attached, find the patch to show what I have in mind for this. Today,
we have received a bug report with a similar symptom [1] and that
should also be fixed with this. The reported bug should also be fixed
with this.

Thoughts?


[1] - https://www.postgresql.org/message-id/CANWRaJyyD%3D9c1E2HdF-Tqfe7%2BvuCQnAkXd6%2BEFwxC0wM%3D313AA%40mail.gmail.com

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix ALTER SUBSCRIPTION ... SET PUBLICATION ... command.

  2. Allow specifying column lists for logical replication