Re: row filtering for logical replication
Amit Kapila <amit.kapila16@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Thu, Jan 20, 2022 at 6:43 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > And the actual reason I was looking at this code, is that I had stumbled > upon the new GetRelationPublicationInfo() function, which has an even > weirder API: > > > * Get the publication information for the given relation. > > * > > * Traverse all the publications which the relation is in to get the > > * publication actions and validate the row filter expressions for such > > * publications if any. We consider the row filter expression as invalid if it > > * references any column which is not part of REPLICA IDENTITY. > > * > > * To avoid fetching the publication information, we cache the publication > > * actions and row filter validation information. > > * > > * Returns the column number of an invalid column referenced in a row filter > > * expression if any, InvalidAttrNumber otherwise. > > */ > > AttrNumber > > GetRelationPublicationInfo(Relation relation, bool validate_rowfilter) > > "Returns *an* invalid column referenced in a RF if any"? That sounds > very strange. And exactly what info is it getting, given that there is > no actual returned info? > It returns an invalid column referenced in an RF if any but if not then it helps to form pubactions which is anyway required at a later point in the caller. The idea is that when we are already traversing publications we should store/gather as much info as possible. I think probably the API name is misleading, maybe we should name it something like ValidateAndFetchPubInfo, ValidateAndRememberPubInfo, or something along these lines? > Maybe this was meant to be "validate RF > expressions" and return, perhaps, a bitmapset of all invalid columns > referenced? > Currently, we stop as soon as we find the first invalid column. > (What is an invalid column in the first place?) > A column that is referenced in the row filter but is not part of Replica Identity. -- With Regards, Amit Kapila.