Horton

Re: Add contrib/pg_logicalsnapinspect

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Andres Freund <andres@anarazel.de>, Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-03-05T09:12:15Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix indentation issue

  2. pg_logicalinspect: Stabilize isolation tests.

  3. Add contrib/pg_logicalinspect.

  4. Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.

On Wed, Mar 5, 2025 at 12:47 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi,
>
> On Tue, Mar 04, 2025 at 10:25:57PM -0800, Masahiko Sawada wrote:
> > On Tue, Mar 4, 2025 at 1:56 PM Andres Freund <andres@anarazel.de> wrote:
> > >
> > Thank you for the report.
>
> +1
>
> > It seems that bgwriter wrote another RUNNING_XACTS record during the
> > test, making the logical decoding write an extra snapshot on the disk.
>
> Yup.
>
> > One way to stabilize the regression test would be that we check if
> > there is a serialized snapshot that has expected number of catchange
> > transactions and number of committed transactions, instead of dumping
> > all serialized snapshots.
>
> Agree, PFA a patch doing so.
>

It would be better if you could add a few comments atop the
permutation line to explain the working of the test. We have it for
other decoding-related tests. See
test_decoding/specs/subxact_without_top.spec for reference.

-- 
With Regards,
Amit Kapila.