Re: [PATCH] Simple progress reporting for COPY command
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Josef Šimánek <josef.simanek@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-08T04:29:36Z
Lists: pgsql-hackers
On Fri, Jan 8, 2021 at 9:45 AM Josef Šimánek <josef.simanek@gmail.com> wrote: > > pá 8. 1. 2021 v 5:03 odesílatel Amit Kapila <amit.kapila16@gmail.com> napsal: > > > > On Fri, Jan 8, 2021 at 8:42 AM Josef Šimánek <josef.simanek@gmail.com> wrote: > > > > > > pá 8. 1. 2021 v 3:55 odesílatel Amit Kapila <amit.kapila16@gmail.com> napsal: > > > > > > > > > > > > Can't we display the entire COPY command? I checked that > > > > pg_stat_statements display the query so there shouldn't be a problem > > > > to display the entire command. > > > > > > In previous discussions there was mentioned it doesn't make sense > > > since you can join with pg_stat_statements on the pid column if > > > needed. What would be the reason to duplicate that info? > > > > > > > But pg_stat_staments won't be present by default. Also, the same > > argument could be applied for the command to be present in > > stat_progress views. It occurred to me only when I was trying to > > compare what we display in all the progress views. I think there is > > some merit in being consistent. > > Sorry, I mean pg_stat_activity (not pg_stat_statements). That is > included by default (at least in my installations). > Okay, that makes sense but I still wonder why we display it in other stat_progress views? -- With Regards, Amit Kapila.
Commits
-
Minor fixes in COPY progress docs
- ebb5457cfa51 14.0 landed
-
Report progress of COPY commands
- 8a4f618e7ae3 14.0 landed