Re: SerializeParamList vs machines with strict alignment

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, hlinnaka <hlinnaka@iki.fi>
Date: 2018-10-04T02:30:41Z
Lists: pgsql-hackers
On Wed, Oct 3, 2018 at 10:02 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Now chipmunk also failed for the same test.
> >
> > >  What I find more interesting is
> > > that both of the live Sparc critters are happy --- so despite
> > > Thomas' statements upthread, they're coping with unaligned accesses.
> > > Maybe you should have back-patched the test to older branches so
> > > we could see what castoroides and protosciurus would do.  But it's
> > > probably not worth additional delay.
> > >
> >
> > Agreed, I will push the code-fix on HEAD and code+test in back-branches.
> >
>
> Pushed, let's wait and see if this can make all the failing buidfarm
> members (due to this issue) happy.
>

All the affected members (gharial, chipmunk, anole) are happy.  It
feels good to see chipmunk becoming green after so many days.  Thanks
a lot, Tom for your assistance.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


Commits

  1. MAXALIGN the target address where we store flattened value.

  2. Test passing expanded-value representations to workers.