Horton

Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Hubert Lubaczewski <depesz@depesz.com>, pgsql-hackers mailing list <pgsql-hackers@postgresql.org>
Date: 2017-12-09T10:30:08Z
Lists: pgsql-hackers

Attachments

On Sat, Dec 9, 2017 at 1:24 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Dec 8, 2017 at 5:11 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>> Okay, I have adjusted the patch accordingly.  I have also added a
>>> regression test which should produce the same result across different
>>> runs, see if that looks okay to you, then it is better to add such a
>>> test as well.
>>
>> The regression test added by patch needs cleanup at the end which I
>> have added in the attached patch.
>
> Hmm.  If we're going this way, then shouldn't we revert the changes
> commit 2c09a5c12a66087218c7f8cba269cd3de51b9b82 made to
> ExecParallelRetrieveInstrumentation?
>

Yeah, it is better to revert it as ideally that is not required after
this patch and that is what I have tried to convey above ("Ideally, it
would have obviated the need for my previous patch which
got committed as 778e78ae." (The commit id is for branch 10,
otherwise, it is same as what you mention.)).  I have locally reverted
that patch and then rebased it on top of that.


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Back-port fix for accumulation of parallel worker instrumentation.

  2. Test instrumentation of Hash nodes with parallel query.

  3. Try again to fix accumulation of parallel worker instrumentation.

  4. Revert "Fix accumulation of parallel worker instrumentation."

  5. Fix accumulation of parallel worker instrumentation.