Horton

Re: Data is copied twice when specifying both child and parent table in publication

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>, Andres Freund <andres@anarazel.de>, vignesh C <vignesh21@gmail.com>, "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Langote <amitlangote09@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>
Date: 2023-03-23T06:51:20Z
Lists: pgsql-hackers 
On Thu, Mar 23, 2023 at 9:57 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are some review comments for patch v20-0001.
>
> ======
> General.
>
> 1.
> That function 'pg_get_publication_tables' does not seem to be
> described in the PG documentation. Why isn't it in the "System Catalog
> Information Functions" table [1] ?
>
> I asked this same question a long time ago but then the reply [2] was
> like "it doesn't seem to be a function provided to users".
>
> Well, perhaps that just means that the documentation has been
> accidentally missing for a long time. Does anybody know for sure if
> the omission of this function from the documentation is deliberate? If
> nobody here knows, then maybe this can be asked/addressed in a
> separate thread.
>

It is better that you start a separate thread to discuss this question
as it is not related to this patch.

-- 
With Regards,
Amit Kapila.

Commits

  1. Avoid syncing data twice for the 'publish_via_partition_root' option.

  2. Fix partition table's REPLICA IDENTITY checking on the subscriber.

  3. Prohibit combining publications with different column lists.

  4. Fix double publish of child table's data.

  5. Support adding partitioned tables to publication