Re: server crashed with TRAP: FailedAssertion("!(!parallel_aware || pathnode->path.parallel_safe)"

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, amul sul <sulamul@gmail.com>
Date: 2018-06-19T03:36:34Z
Lists: pgsql-hackers

Attachments

On Mon, Jun 18, 2018 at 3:09 PM, Amit Khandekar <amitdkhan.pg@gmail.com> wrote:
> On 16 June 2018 at 19:30, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> On Sat, Jun 16, 2018 at 10:44 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>> Yeah, or perhaps disallow creation of any partial paths at the first
>>> place like in attached.   This will save us some work as well.
>>>
>>
>> Attached patch contains test case as well.  I have tried to come up
>> with some simple test, but couldn't come up with anything much simpler
>> than reported by Rajkumar, so decided to use the test case provided by
>> him.
>>
>
> Thanks for the patch. I had a look at it, and it looks good to me. One
> minor comment :
>
> +-- Parallel Append is not be used when the subpath depends on the outer param
> "is not be used" => "is not to be used"
>

Fixed in the attached patch.  I will wait for a day or two to see if
Tom or Robert wants to say something and then commit.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Improve coding pattern in Parallel Append code.

  2. Support Parallel Append plan nodes.