Re: pgsql: Prevent invalidation of newly synced replication slots.

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-28T04:33:51Z
Lists: pgsql-hackers
On Tue, Jan 27, 2026 at 8:29 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Tue, Jan 27, 2026 at 12:56 AM Amit Kapila <akapila@postgresql.org> wrote:
> > Prevent invalidation of newly synced replication slots.
>
> This commit has broken CI for me. On the "Windows - Server 2022, VS
> 2019 - Meson & ninja" build, the following shows up in
> 046_checkpoint_logical_slot_standby.log:
>
> 2026-01-27 13:44:44.421 GMT startup[5172] FATAL:  could not rename
> file "backup_label" to "backup_label.old": Permission denied
>
> I imagine this is going to break CI for everybody else too, as well as cfbot.
>

I'll try to reproduce and look into it.

-- 
With Regards,
Amit Kapila.



Commits

  1. Fix CI failure introduced in commit 851f6649cc.

  2. Prevent invalidation of newly synced replication slots.

  3. Prevent invalidation of newly created replication slots.