Horton

Re: CREATE SUBSCRIPTION -- add missing tab-completes

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-07T05:28:11Z
Lists: pgsql-hackers

Attachments

On Wed, Apr 5, 2023 at 5:58 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> There are some recent comment that added new options for CREATE SUBSCRIPTION
>
...
> PSA patches to add those tab completions.
>

LGTM, so pushed. BTW, while looking at this, I noticed that newly
added options "password_required" and "run_as_owner" has incorrectly
mentioned their datatype as a string in the docs. It should be
boolean. I think "password_required" belongs to first section of docs
which says: "The following parameters control what happens during
subscription creation".

The attached patch makes those changes. What do you think?

-- 
With Regards,
Amit Kapila.

Commits

  1. Doc: Fix the datatype of the newly added SUBSCRIPTION options.

  2. Add tab-completion for newly added SUBSCRIPTION options.

  3. Add a run_as_owner option to subscriptions.

  4. Add new predefined role pg_create_subscription.