Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>, Keisuke Kuroda <keisuke.kuroda.3862@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-15T07:08:49Z
Lists: pgsql-hackers
On Wed, Oct 14, 2020 at 4:51 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Wed, Oct 14, 2020 at 4:12 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> >
> > Thanks for the tests. The latest patch looks mostly good to me. I have
> > made minor changes to the patch (a) changed the order where the new
> > message is placed at one place to make it consistent with other
> > places, (b) as discussed offlist, removed the extra increment to a
> > local variable in ReorderBufferRestoreChange, (c) ran pgindent.
> >
> > See the attached and let me know what do you think?
>
> The changes look good to me.
>

Pushed!

-- 
With Regards,
Amit Kapila.



Commits

  1. Execute invalidation messages for each XLOG_XACT_INVALIDATIONS message

  2. WAL Log invalidations at command end with wal_level=logical.