Re: Data is copied twice when specifying both child and parent table in publication
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
Greg Nancarrow <gregn4422@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
Dilip Kumar <dilipbalaut@gmail.com>
Date: 2021-11-04T04:13:45Z
Lists: pgsql-hackers
On Wed, Nov 3, 2021 at 3:43 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Thu, Oct 28, 2021 at 1:55 PM Amit Langote <amitlangote09@gmail.com> wrote: > > > > > > Thanks for the summary, Hou-san, and sorry about my late reply. > > > > I had thought about this some last week and I am coming around to > > recognizing the confusing user experience of the current behavior. > > Though, I am not sure if removing partitions from the result of > > pg_publication_tables view for pubviaroot publications is acceptable > > as a fix, because that prevents replicating into a subscriber node > > where tables that are partition root and a partition respectively on > > the publisher are independent tables on the subscriber. > > > > But we already do that way when the publication is "For All Tables". > Anyway, for the purpose of initial sync, it will just replicate the > same data in two different tables if the corresponding tables on the > subscriber-side are non-partitioned which I am not sure is what the > user will be expecting. > On further thinking about this, I think we should define the behavior of replication among partitioned (on the publisher) and non-partitioned (on the subscriber) tables a bit more clearly. - If the "publish_via_partition_root" is set for a publication then we can always replicate to the table with the same name as the root table in publisher. - If the "publish_via_partition_root" is *not* set for a publication then we can always replicate to the tables with the same name as the non-root tables in publisher. Thoughts? -- With Regards, Amit Kapila.
Commits
-
Avoid syncing data twice for the 'publish_via_partition_root' option.
- 062a84442424 16.0 landed
-
Fix partition table's REPLICA IDENTITY checking on the subscriber.
- 52d5ea9adb01 14.5 cited
-
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 cited
-
Fix double publish of child table's data.
- 3f06c00cf6dc 13.6 landed
- 614b77d65a38 14.2 landed
- 5e97905a2c76 15.0 landed
-
Support adding partitioned tables to publication
- 17b9e7f9fe23 13.0 cited