Horton

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Shubham Khanna <khannashubham1197@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Nisha Moond <nisha.moond412@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>
Date: 2025-03-26T05:10:05Z
Lists: pgsql-hackers 
On Tue, Mar 25, 2025 at 5:24 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Tue, Mar 25, 2025 at 5:15 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Mar 25, 2025 at 5:08 PM Ashutosh Bapat
> > <ashutosh.bapat.oss@gmail.com> wrote:
> > >
> > > This looks mostly ready except the test changes. I believe when
> > > committing, we are going to squash all three into a single commit. Is
> > > that correct?
> > >
> >
> > I would not prefer to commit 0003 as it is primarily because of test
> > +# run pg_createsubscriber with '--all' option without '--dry-run'. I
> > am not so sure whether it is really worth adding test cycles for this
> > option except for dry-run mode tests but we can discuss after
> > committing the core patch.
>
> I am worried that without that test, we won't catch bugs in creating
> slots, publications and subscriptions and thus causing problems in a
> setup with --all.
>

The -all option internally maps to -d switches, so the current tests
with that option should suffice for the need you are expecting.

-- 
With Regards,
Amit Kapila.

Commits

  1. Cosmetic fixes for pg_createsubscriber's -all option.

  2. pg_createsubscriber: Add '--all' option.