Horton
Menu

Re: Proposal: Conflict log history table for Logical Replication

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, shveta malik <shveta.malik@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-25T13:07:06Z
Lists: pgsql-hackers 
On Thu, Jun 25, 2026 at 6:30 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Thu, Jun 25, 2026 at 4:57 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
>
> > 2.
> > @@ -2482,6 +2681,8 @@ DropSubscription(DropSubscriptionStmt *stmt,
> > bool isTopLevel)
> >   deleteDependencyRecordsFor(SubscriptionRelationId, subid, false);
> >   deleteSharedDependencyRecordsFor(SubscriptionRelationId, subid, 0);
> >
> > + drop_sub_conflict_log_table(subid, subname, subconflictlogrelid);
> >
> > It would be better to drop the table before cleaning up the dependency
> > record. Right now, it is okay even in current order because dependency
> > removal is trying to remove where subid is depender.
>
> So whats your suggestion change it now or not?  I feel either way is fine.
>

Let's change now itself.

-- 
With Regards,
Amit Kapila.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow logical replication conflicts to be logged to a table.

  2. Avoid orphaned objects dependencies