Re: Loaded footgun open_datasync on Windows

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-06T09:09:35Z
Lists: pgsql-hackers
On Wed, Jun 6, 2018 at 10:18 AM, Michael Paquier <michael@paquier.xyz>
wrote:

> On Wed, Jun 06, 2018 at 09:58:34AM +0530, Amit Kapila wrote:
>
> >> It could be
> >> risky for existing callers of open() for tool maintainers, or on the
> >> contrary people could welcome a wrapper of open() which is
> >> concurrent-safe in their own tools.
> >
> > I am not sure if we can safely assume that because using these functions
> > would allow users to concurrently delete the files, but may be it is okay
> > for all the FRONTEND modules.  One another alternative could be that we
> > define open as pgwin32_open (for WIN32) wherever we need it.
>
> Which is what basically happens on any *nix platform, are you foreseeing
> anything bad here?


>
Nothing apparent, but I think we should try to find out why at the first
place this has been made backend specific.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Allow concurrent-safe open() and fopen() in frontend code for Windows

  2. Fix inclusions of c.h from .h files.

  3. Allow borland compiles.

  4. Corrects issues recently posted by Dann Corbit, allowing libpq/psql to