Re: Bugs in pgoutput.c
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Hou, Zhijie/侯 志杰 <houzj.fnst@fujitsu.com>
Date: 2022-02-03T11:54:35Z
Lists: pgsql-hackers
Attachments
- v2-0001-Improve-invalidation-handling-in-pgoutput.c.patch (application/octet-stream) patch v2-0001
On Thu, Feb 3, 2022 at 8:18 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Amit Kapila <amit.kapila16@gmail.com> writes: > > Tom, is it okay for you if I go ahead with this patch after some testing? > > I've been too busy to get back to it, so sure. > Thanks. I have tested the patch by generating an invalidation message for table DDL before accessing the syscache in logicalrep_write_tuple(). I see that it correctly invalidates the entry and rebuilds it for the next operation. I couldn't come up with some automatic test for it so used the debugger to test it. I have made a minor change in one of the comments. I am planning to push this tomorrow unless there are comments or suggestions. -- With Regards, Amit Kapila.
Commits
-
Improve invalidation handling in pgoutput.c.
- 7f481b8d3884 15.0 landed
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited