Re: Notify downstream to discard the streamed transaction which was aborted due to crash.
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-01-07T10:30:32Z
Lists: pgsql-hackers
On Fri, Jan 6, 2023 at 11:18 AM Dilip Kumar <dilipbalaut@gmail.com> wrote: > > > > > To fix it, One idea is to send a stream abort message when we are cleaning up > > crashed transaction on publisher(e.g. in ReorderBufferAbortOld()). And here is > > a tiny patch which changes the same. I have confirmed that the bug is fixed and > > all regression tests pass. I didn't add a testcase because we need to make sure > > the crash happens before all the WAL logged transactions data are decoded which > > doesn't seem easy to write a stable test for this. > > > > Thoughts ? > > Fix looks good to me. Thanks for working on this. > Pushed! -- With Regards, Amit Kapila.
Commits
-
Remove the streaming files for incomplete xacts after restart.
- 2b6df05461cb 16.0 landed
- 18b81258ab60 15.2 landed
- b2cc5b81001a 14.7 landed