Horton

Re: A doubt about a newly added errdetail

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2022-09-26T12:03:46Z
Lists: pgsql-hackers 
On Mon, Sep 26, 2022 at 4:45 PM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
>
> Attach the patch. (The patch can apply on both HEAD and PG15)
>

The patch looks good to me.

*
- errmsg("cannot add schema to the publication"),
+ errmsg("cannot add schema to publication \"%s\"",
+    stmt->pubname),

I see that you have improved an additional message in the patch which
appears okay to me.

-- 
With Regards,
Amit Kapila.

Commits

  1. Remove publicationcmds.c's expr_allowed_in_node as a function

  2. Improve some publication-related error messages