Re: [PoC] pg_upgrade: allow to upgrade publisher node

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>

To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

Cc: Dilip Kumar <dilipbalaut@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bruce Momjian <bruce@momjian.us>, Julien Rouhaud <rjuju123@gmail.com>, vignesh C <vignesh21@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>

Date: 2023-09-19T12:27:31Z

Lists: pgsql-hackers

Attachments

v40-0001-pg_upgrade-Allow-to-replicate-logical-replicatio.patch (application/octet-stream) patch v40-0001

On Tue, Sep 19, 2023 at 11:47 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Amit,
>
> Thank you for reviewing! PSA new version!
>

*
+#include "access/xlogdefs.h"
 #include "common/relpath.h"
 #include "libpq-fe.h"

The above include is not required. I have removed that and made a few
cosmetic changes in the attached.

-- 
With Regards,
Amit Kapila.

Commits

Fix issues in binary_upgrade_logical_slot_has_caught_up().
- 0bf62460bb9e 17.0 landed
Fix a random failure in 003_logical_slots.pl.
- 63c5df126abb 17.0 landed
Fix a test in 003_logical_slots.
- 3e36e48d8efe 17.0 landed
Fix uninitialized slot array access during the upgrade.
- a7db71ed2787 17.0 landed
Fix the test 003_logical_slots.
- 8af917be6bad 17.0 landed
Commit b195e6d482 forgot to update meson.build.
- 8949b978ff49 17.0 landed
Use shorter file names in the upgrade logical slots test.
- b195e6d482b8 17.0 landed
Migrate logical slots to the new node during an upgrade.
- 29d0a77fa660 17.0 landed
Flush logical slots to disk during a shutdown checkpoint if required.
- e0b2eed047df 17.0 landed
Prevent possibility of panics during shutdown checkpoint.
- c6c333436491 10.0 cited