Re: Conflict detection for update_deleted in logical replication

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>
Date: 2025-08-14T11:48:21Z
Lists: pgsql-hackers
On Thu, Aug 14, 2025 at 9:02 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Wed, Aug 13, 2025 at 5:42 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > >
> > > 4)
> > > For the DETAIL part of resume and stop messages, how about these:
> > >
> > > The retention duration for information used in conflict detection has
> > > exceeded the limit of xx.
> > > The retention duration for information used in conflict detection is
> > > now within the acceptable limit of xx.
> > > The retention duration for information used in conflict detection is
> > > now indefinite.
> > >
> >
> > Similar to the previous point, will it be better to keep it short by
> > using "conflict detection info", for example, it will lead to message
> > like "The retention duration for conflict detection info is now
> > indefinite."?
> >
>
> Works for me as I understand the context. But could it be confusing
> for users? Could it be inferred as info about conflicts rather than
> info used while detecting conflicts?
>

Fair point. We can retain your proposed message.

-- 
With Regards,
Amit Kapila.



Commits

  1. Fix intermittent BF failures in 035_conflicts.

  2. Resume conflict-relevant data retention automatically.

  3. Fix intermittent test failure introduced in 6456c6e2c4.

  4. Fix Coverity issue reported in commit a850be2fe.

  5. Add test to prevent premature removal of conflict-relevant data.

  6. Post-commit review fixes for 228c370868.

  7. Add max_retention_duration option to subscriptions.

  8. Detect and report update_deleted conflicts.

  9. Preserve conflict-relevant data during logical replication.

  10. Integrate FullTransactionIds deeper into two-phase code

  11. Improve checks for GUC recovery_target_timeline

  12. Prevent excessive delays before launching new logrep workers.

  13. Keep WAL segments by slot's last saved restart LSN

  14. Rework some code handling pg_subscription data in psql and pg_dump

  15. Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.