Horton

Re: walsender.c comment with no context is hard to understand

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Michael Paquier <michael@paquier.xyz>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-07-08T05:50:45Z
Lists: pgsql-hackers 
On Mon, Jul 8, 2024 at 11:08 AM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> On Mon, Jul 08, 2024 at 08:46:19AM +0530, Amit Kapila wrote:
> > This sounds better but it is better to add just before we determine
> > am_cascading_walsender as is done in the attached. What do you think?
>
> Thanks! LGTM.
>

I would like to push this to HEAD only as we don't see any bug that
this change can prevent. What do you think?

-- 
With Regards,
Amit Kapila.

Commits

  1. To improve the code, move the error check in logical_read_xlog_page().

  2. Allow logical decoding on standbys

  3. Fix walsender to exit promptly if client requests shutdown.