Re: Adding clarification to description of IPC wait events XactGroupUpdate and ProcArrayGroupUpdate
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: SAMEER KUMAR <sameer.kasi200x@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2024-08-20T08:42:25Z
Lists: pgsql-hackers
On Thu, Aug 15, 2024 at 8:11 PM Nathan Bossart <nathandbossart@gmail.com> wrote: > > On Thu, Aug 15, 2024 at 11:25:25AM +0800, SAMEER KUMAR wrote: > > I think it is important to indicate that the group leader is responsible > > for clearing the transaction ID/transaction status of other backends > > (including this one). > > Your proposal is > > Waiting for the group leader process to clear the transaction ID of > this backend at the end of a transaction. > > Waiting for the group leader process to update the transaction status > for this backend. > > Mine is > > Waiting for the group leader to clear the transaction ID at transaction > end. > > Waiting for the group leader to update transaction status at > transaction end. > > IMHO the latter doesn't convey substantially less information, and it fits > a little better with the terse style of the other wait events nearby. > +1 for Nathan's version. It is quite close to the previous version, for which we haven't heard any complaints since they were introduced. -- With Regards, Amit Kapila.
Commits
-
Fix a couple of wait event descriptions.
- effc4c9a666c 17.0 landed
- 845f9835e807 16.5 landed
- 6bc2bfc339ab 14.14 landed
- 5ff9b6b4d981 18.0 landed
- 5d9170697e4e 15.9 landed
- 18e3e290bc6f 13.17 landed
-
Mop-up for wait event naming issues.
- 3048898e73c7 13.0 cited