Re: row filtering for logical replication
Amit Kapila <amit.kapila16@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
On Tue, Dec 21, 2021 at 12:28 AM Euler Taveira <euler@eulerto.com> wrote: > > On Mon, Dec 20, 2021, at 12:10 AM, houzj.fnst@fujitsu.com wrote: > > Attach the V49 patch set, which addressed all the above comments on the 0002 > patch. > > I've been testing the latest versions of this patch set. I'm attaching a new > patch set based on v49. The suggested fixes are in separate patches after the > current one so it is easier to integrate them into the related patch. The > majority of these changes explains some decision to improve readability IMO. > > row-filter x row filter. I'm not a native speaker but "row filter" is widely > used in similar contexts so I suggest to use it. (I didn't adjust the commit > messages) > > An ancient patch use the term coerce but it was changed to cast. Coercion > implies an implicit conversion [1]. If you look at a few lines above you will > see that this expression expects an implicit conversion. > > I modified the query to obtain the row filter expressions to (i) add the schema > pg_catalog to some objects and (ii) use NOT EXISTS instead of subquery (it > reads better IMO). > Yeah, I think that reads better, but maybe we can once check the plan of both queries and see if there is any significant difference between one of those. > A detail message requires you to capitalize the first word of sentences and > includes a period at the end. > > It seems all server messages and documentation use the terminology "WHERE > clause". Let's adopt it instead of "row filter". > > I reviewed 0003. It uses TupleTableSlot instead of HeapTuple. I probably missed > the explanation but it requires more changes (logicalrep_write_tuple and 3 new > entries into RelationSyncEntry). I replaced this patch with a slightly > different one (0005 in this patch set) that uses HeapTuple instead. I didn't > only simple tests and it requires tests. I noticed that this patch does not > include a test to cover the case where TOASTed values are not included in the > new tuple. We should probably add one. > Yeah, it would be good to add such a test. -- With Regards, Amit Kapila.