Horton

Re: Added schema level support for publication.

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Greg Nancarrow <gregn4422@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-10-25T09:39:01Z
Lists: pgsql-hackers 
On Mon, Oct 25, 2021 at 1:11 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, Oct 25, 2021 at 10:52 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Fri, Oct 22, 2021 at 8:56 PM vignesh C <vignesh21@gmail.com> wrote:
> > >
> >
> > I am getting a compilation error in the latest patch on HEAD. I think
> > was relying on some variable removed by a recent commit
> > 92316a4582a5714d4e494aaf90360860e7fec37a. While looking at that
> > compilation error, I observed that we don't need the second and third
> > parameters in pg_dump.c/getPublicationNamespaces() as those are not
> > getting used.
>
> I have fixed this in the v47 version attached.
>

Thanks, the first patch in the series "Allow publishing the tables of
schema." looks good to me. Unless there are more
comments/bugs/objections, I am planning to commit it in a day or so.

-- 
With Regards,
Amit Kapila.

Commits

  1. Include schema/table publications even with exclude options in dump.

  2. Rename some enums to use TABLE instead of REL.

  3. Add tap tests for the schema publications.

  4. Allow publishing the tables of schema.

  5. In pg_dump, use simplehash.h to look up dumpable objects by OID.