Re: GatherMerge misses to push target list
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Rushabh Lathia <rushabh.lathia@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-11-12T07:29:50Z
Lists: pgsql-hackers
On Sat, Nov 11, 2017 at 5:05 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Mon, Sep 18, 2017 at 7:02 AM, Rushabh Lathia > <rushabh.lathia@gmail.com> wrote: >>> In that case, can you please mark the patch [1] as ready for committer in >>> CF app >> >> Done. > > I think this patch is mostly correct, but I think the change to > planner.c isn't quite right. ordered_rel->reltarget is just a dummy > target list that produces nothing. Instead, I think we should pass > path->pathtarget, representing the idea that whatever Gather Merge > produces as output is the same as what you put into it. > Agreed. Your change looks good to me. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
Commits
-
Push target list evaluation through Gather Merge.
- 44ae64c388bd 11.0 landed