Horton

Re: Logical Replication of sequences

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Chao Li <li.evan.chao@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>
Date: 2025-10-09T06:07:45Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Add documentation for sequence synchronization.

  2. Remove unused assignment in CREATE PUBLICATION grammar.

  3. Add seq_sync_error_count to subscription statistics.

  4. Fix few issues in commit 5509055d69.

  5. Add sequence synchronization for logical replication.

  6. Add worker type argument to logical replication worker functions.

  7. Introduce "REFRESH SEQUENCES" for subscriptions.

  8. Refactor logical worker synchronization code into a separate file.

  9. Standardize use of REFRESH PUBLICATION in code and messages.

  10. Add "ALL SEQUENCES" support to publications.

  11. Expose sequence page LSN via pg_get_sequence_data.

  12. Resume conflict-relevant data retention automatically.

  13. Post-commit review fixes for 228c370868.

  14. Generate GUC tables from .dat file

On Thu, Oct 9, 2025 at 11:21 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> I saw a sequence replication patch was committed recently [1], so I
> was looking at the diffs. Below are a couple of observations:
>
> //////////
>
> 1.
> The following message seems overly long:
> errmsg("publication parameters are not applicable to sequence
> synchronization and will be ignored for sequences"));
>
> I saw the message was already discussed here [2], but at that time, it
> was not shortened much.
>
> How about something shorter? Some examples.
> errmsg("publication parameters will be ignored for sequences"));
> errmsg("publication parameters will be ignored for sequence replication"));
>

I thought about these alternatives but left in favor of clarity with a
longer message. However, I am fine to change if others also think so.
Let's wait and see if others have an opinion on this point.

> ======
>
> 2.
> +-- Specifying WITH clause in an ALL SEQUENCES publication will emit a NOTICE.
> +SET client_min_messages = 'NOTICE';
> +CREATE PUBLICATION regress_pub_for_allsequences_alltables_withclause
> FOR ALL SEQUENCES, ALL TABLES WITH (publish = 'insert');
> +CREATE PUBLICATION regress_pub_for_allsequences_withclause FOR ALL
> SEQUENCES WITH (publish_generated_columns = 'stored');
> +RESET client_min_messages;
>
> Why not also test WITH('publish_via_partition_root')?
>

It is not required to write a test with all the options, the current
set chosen seems sufficient.

-- 
With Regards,
Amit Kapila.