Horton

Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Christoph Berg <myon@debian.org>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2020-01-08T02:59:38Z
Lists: pgsql-hackers 
On Mon, Jan 6, 2020 at 4:26 PM Christoph Berg <myon@debian.org> wrote:
>
> Re: Tom Lane 2020-01-05 <25771.1578249042@sss.pgh.pa.us>
>
> Ubuntu bionic fails elsewhere:
>
> 07:19:51 t/001_stream_rep.pl .................. ok
> 07:19:53 t/002_archiving.pl ................... ok
> 07:19:59 t/003_recovery_targets.pl ............ ok
> 07:20:01 t/004_timeline_switch.pl ............. ok
> 07:20:08 t/005_replay_delay.pl ................ ok
> 07:20:10 Bailout called.  Further testing stopped:  system pg_ctl failed
> 07:20:10 FAILED--Further testing stopped: system pg_ctl failed
>
> 07:20:10 2020-01-06 06:19:41.285 UTC [26415] LOG:  received fast shutdown request
> 07:20:10 2020-01-06 06:19:41.285 UTC [26415] LOG:  aborting any active transactions
> 07:20:10 2020-01-06 06:19:41.287 UTC [26415] LOG:  background worker "logical replication launcher" (PID 26424) exited with exit code 1
> 07:20:10 2020-01-06 06:19:41.287 UTC [26419] LOG:  shutting down
> 07:20:10 2020-01-06 06:19:41.287 UTC [26419] LOG:  checkpoint starting: shutdown immediate
>

It looks like this failure is more of what we are getting on
"sidewinder" where it failed because of "insufficient file descriptors
available to start server process".  Can you check in the log
(probably in 006_logical_decoding_master.log) if this is the same you
are getting or something else.


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Skip tab-completion tests if envar SKIP_READLINE_TESTS is defined.

  2. Minor style improvements for tab-completion test.

  3. Avoid reading ~/.inputrc in tab-completion test, and revert other changes.

  4. Don't try to force TERM to a fixed value in tab-completion test.

  5. In tab-completion test, print out the value of TERM before changing it.

  6. Make tab-completion tests more robust.

  7. Further fixes for tab-completion TAP tests.

  8. Add an ugly workaround for a bug in some recent libedit versions.

  9. Add basic TAP tests for psql's tab-completion logic.

  10. Fix running out of file descriptors for spill files.