Horton

Thread

Commits

  1. Remove obsolete comment in snapbuild.c.

  1. Remove an obsolete comment in snapbuild.c

    Masahiko Sawada <sawada.mshk@gmail.com> — 2021-10-04T07:53:28Z

    Hi all,

While reading the code I realized that the following comment of
SnapBuildOnDick is obsolete:

/*
 * We store current state of struct SnapBuild on disk in the following manner:
 *
 * struct SnapBuildOnDisk;
 * TransactionId * running.xcnt_space;
 * TransactionId * committed.xcnt; (*not xcnt_space*)
 *
 */
typedef struct SnapBuildOnDisk

Since SnapBuild has no longer "running" struct, it should be removed.
Please find an attached patch.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

  2. Re: Remove an obsolete comment in snapbuild.c

    Amit Kapila <amit.kapila16@gmail.com> — 2021-10-04T08:37:39Z

    On Mon, Oct 4, 2021 at 1:24 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Hi all,
>
> While reading the code I realized that the following comment of
> SnapBuildOnDick is obsolete:
>
> /*
>  * We store current state of struct SnapBuild on disk in the following manner:
>  *
>  * struct SnapBuildOnDisk;
>  * TransactionId * running.xcnt_space;
>  * TransactionId * committed.xcnt; (*not xcnt_space*)
>  *
>  */
> typedef struct SnapBuildOnDisk
>
> Since SnapBuild has no longer "running" struct, it should be removed.
> Please find an attached patch.
>

LGTM. I'll push this tomorrow unless someone thinks otherwise.

-- 
With Regards,
Amit Kapila.