Re: Failure of subscription tests with topminnow
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Ajin Cherian <itsajin@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-25T06:22:04Z
Lists: pgsql-hackers
On Wed, Aug 25, 2021 at 8:00 AM Ajin Cherian <itsajin@gmail.com> wrote: > > On Tue, Aug 24, 2021 at 11:12 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > But will poll function still poll or exit? Have you tried that? > > I have forced that condition with a changed query and found that the > poll will not exit in case of a NULL return. > What if the query in a poll is fired just before we get an error "tap_sub ERROR: replication slot "tap_sub" is active for PID 16336"? Won't at that stage both old and new walsender's are present, so the query might return true. You can check that via debugger by stopping just before this error occurs and then check pg_stat_replication view. > > I will try with REL_11_STABLE and see if the behaviour is different. > Okay, but I still suspect some timing issue here. -- With Regards, Amit Kapila.
Commits
-
Fix the random test failure in 001_rep_changes.
- 8d0138ef51b5 15.0 landed
- b7ad093d50e1 14.0 landed
- 387093e43225 10.19 landed
- 56683e1684ef 11.14 landed
- df6ab94aca90 12.9 landed
- b51985d8a0e1 13.5 landed