Horton

Re: Proposal: Conflict log history table for Logical Replication

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shvetamalik@gmail.com>
Date: 2026-05-27T23:08:11Z
Lists: pgsql-hackers 
On Tue, May 26, 2026 at 2:38 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> 2)
> drop_subscription_dependencies():
>
> + conflictrelname = get_rel_name(subconflictlogrelid);
>
> We can actually have a sanity check that we got the CLT using the relid.
> Assert(conflictrelname != NULL);
>

elog will suit this place better as this can't be a direct coding
mistake. I see that at other places we used elog. See
if (result == NULL)
elog(ERROR, "cache lookup failed for index %u", indexId);

-- 
With Regards,
Amit Kapila.