Re: Allow streaming the changes after speculative aborts.
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-30T08:14:57Z
Lists: pgsql-hackers
On Wed, Jun 30, 2021 at 9:55 AM Dilip Kumar <dilipbalaut@gmail.com> wrote: > > On Wed, Jun 30, 2021 at 9:29 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > On Tue, Jun 29, 2021 at 12:57 PM Dilip Kumar <dilipbalaut@gmail.com> wrote: > > > > > > On Fri, Jun 25, 2021 at 12:24 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > > > Till now, we didn't allow to stream the changes in logical replication > > > > till we receive speculative confirm or the next DML change record > > > > after speculative inserts. The reason was that we never use to process > > > > speculative aborts but after commit 4daa140a2f it is possible to > > > > process them so we can allow streaming once we receive speculative > > > > abort after speculative insertion. See attached. > > > > > > > > I think this is a minor improvement in the logical replication of > > > > in-progress transactions. I have verified this for speculative aborts > > > > and it allows streaming once we receive the spec_abort change record. > > > > > > Yeah, this improvement makes sense. And the patch looks fine to me. > > > > > > > Thanks. Now, that the PG-15 branch is created, I think we should > > commit this to both 15 and 14 as this is a minor change. What do you > > think? > > Yeah, this is a minor improvement so can be pushed to both 15 and 14. > Thanks, pushed! -- With Regards, Amit Kapila.
Commits
-
Allow streaming the changes after speculative aborts.
- dfceed30abc1 14.0 landed
- 52d26d560e27 15.0 landed
-
Fix decoding of speculative aborts.
- 4daa140a2f50 14.0 cited