Horton

Re: parallel vacuum comments

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>
Date: 2021-12-10T12:08:43Z
Lists: pgsql-hackers

Attachments

On Thu, Dec 9, 2021 at 6:05 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Thu, Dec 9, 2021 at 7:44 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> Agreed with the above two points.
>
> I've attached updated patches that incorporated the above comments
> too. Please review them.
>

I have made the following minor changes to the 0001 patch: (a) An
assert was removed from dead_items_max_items() which I added back. (b)
Removed an unnecessary semicolon from one of the statements in
compute_parallel_vacuum_workers(). (c) Changed comments at a few
places. (d) moved all parallel_vacuum_* related functions together.
(e) ran pgindent and slightly modify the commit message.

Let me know what you think of the attached?

-- 
With Regards,
Amit Kapila.

Commits

  1. Move parallel vacuum code to vacuumparallel.c.

  2. Move index vacuum routines to vacuum.c.

  3. Improve parallel vacuum implementation.

  4. Fix parallel amvacuumcleanup safety bug.

  5. Simplify state managed by VACUUM.