Horton

Re: CREATE SUBSCRIPTION -- add missing tab-completes

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-10T03:16:31Z
Lists: pgsql-hackers 
On Sun, Apr 9, 2023 at 11:33 AM Gregory Stark (as CFM)
<stark.cfm@gmail.com> wrote:
>
> On Fri, 7 Apr 2023 at 01:28, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Wed, Apr 5, 2023 at 5:58 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > > PSA patches to add those tab completions.
> >
> > LGTM, so pushed.
>
> I moved this to the next CF but actually I just noticed the thread
> starts with the original patch being pushed. Maybe we should just
> close the CF entry? Is this further change relevant?
>

I have closed the CF entry as the patch for which this entry was
created is already committed. If anything comes as a result of further
discussion, I'll take care of it, or if required we can start a
separate thread.

-- 
With Regards,
Amit Kapila.

Commits

  1. Doc: Fix the datatype of the newly added SUBSCRIPTION options.

  2. Add tab-completion for newly added SUBSCRIPTION options.

  3. Add a run_as_owner option to subscriptions.

  4. Add new predefined role pg_create_subscription.