Horton

Re: Reject negative max_retention_duration values

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@lists.postgresql.org>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Date: 2026-06-09T14:24:36Z
Lists: pgsql-hackers 
On Tue, Jun 9, 2026 at 1:35 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
 ```
>
> It only checks !MySubscription->maxretention, so a negative value will pass. Then, in TimestampDifferenceExceeds, the negative value is counted, causing the actual wait time to be shorter than the intended value.
>

Thanks for the report and analysis. On first read, it sounds correct
to me, I'll spend some more time and share my feedback.

-- 
With Regards,
Amit Kapila.

Commits

  1. Disallow negative values for max_retention_duration.