Re: hash_xlog_split_allocate_page: failed to acquire cleanup lock

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Mark Dilger <mark.dilger@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2022-11-01T03:49:32Z
Lists: pgsql-hackers
On Mon, Oct 31, 2022 at 10:40 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Mon, Oct 31, 2022 at 7:27 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > Agreed, I think the important point to decide is what to do for
> > back-branches. We have the next minor release in a few days' time and
> > this is the last release for v10. I see the following options based on
> > the discussion here.
> >
> > a. Use the code change in 0001 from email [1] and a comment change
> > proposed by Robert in email [2] to fix the bug reported. This should
> > be backpatched till v10. Then separately, we can consider committing
> > something like 0002 from email [1] as a HEAD-only patch.
> > b. Use the code change in 0001 from email [1] to fix the bug reported.
> > This should be backpatched till v10. Then separately, we can consider
> > committing something like 0002 from email [1] as a HEAD-only patch.
> > c. Combine 0001 and 0002 from the email [1] and push them in all
> > branches till v10.
> >
> > I prefer going with (a).
>
> I vote for (a) or (b) for now, and we can consider what else to do
> later.
>

I am fine with any of those. Would you like to commit or do you prefer
me to take care of this?

-- 
With Regards,
Amit Kapila.



Commits

  1. Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.