Horton

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Andres Freund <andres@2ndquadrant.com>, Josh Berkus <josh@agliodbs.com>, Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <masao.fujii@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2013-08-20T03:08:52Z
Lists: pgsql-hackers 
On Tue, Aug 20, 2013 at 8:27 AM, Stephen Frost <sfrost@snowman.net> wrote:
> * Amit Kapila (amit.kapila16@gmail.com) wrote:
>> If both are okay, then I would like to go with second option (include
>> file mechanism).
>> I think by default, we should allow auto file to be included and if
>> user faces any problem or otherwise,
>> then he can decide to disable it.
>
> If it's enabled by default, then we need to ship an 'auto' file which is
> empty by default...

initdb will create the empty auto file. If we don't enable by default,
then if user uses
ALTER SYSTEM and do sighup/restart, changed config parameter values
will not come into affect
until he manually enables it by removing '#' from '#include'.

> I don't particularly like that (implies that an
> empty file is acceptable and not an error condition, which it otherwise
> probably would be...).  I'm still not a big fan of enabling it by default
> tho.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com