Re: doc: pgevent.dll location
Amit Kapila <amit.kapila16@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
To: Dave Page <dpage@pgadmin.org>
Cc: Peter Eisentraut <peter@eisentraut.org>, "Ryohei Takahashi (Fujitsu)" <r.takahashi_2@fujitsu.com>,
Robert Haas <robertmhaas@gmail.com>, Gurjeet Singh <gurjeet@singh.im>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-11T11:11:51Z
Lists: pgsql-hackers
On Thu, Nov 7, 2024 at 1:46 PM Dave Page <dpage@pgadmin.org> wrote: > > Hi > > On Wed, 6 Nov 2024 at 16:11, Peter Eisentraut <peter@eisentraut.org> wrote: >> >> On 06.11.24 13:57, Ryohei Takahashi (Fujitsu) wrote: >> > The dll install paths are changed as follows on Windows. >> > >> > (1) pgevent.dll >> > PG16: lib/ >> > PG17: bin/ >> > >> > (2) dll for user (like libpq.dll, libecpg.dll) >> > PG16: Both in lib/ and bin/ >> > PG17: bin/ >> > >> > (3) contrib dll (like amcheck.dll) >> > PG16: lib/ >> > PG17: lib/ >> > >> > >> > I understand that Dave says (1) and (2) should exist on bin/ directory >> > and the paths in PG17 are correct. >> > >> > So, I think it is correct to update documentation. >> >> I don't have Windows handy to test it out, but looking at the respective >> build system source files, in master, pgevent is built and installed >> like a normal shared library in both meson.build and Makefile, so it >> should end up somewhere in lib. >> >> In src/tools/msvc in REL_16_STABLE, I see some code that appears to >> suggest that it installs in bin. >> >> Again, this is just reading the code, but it seems to be backwards from >> what is claimed earlier. > > > I downloaded the builds of v16 and v17 from > https://github.com/dpage/winpgbuild/actions/runs/11639786998, a project worked on by Andres, Dave Cramer, and myself. > > I've just double-checked I didn't get mixed up, and can confirm that in v17, pgevent.dll is installed into bin/ and in v16.4, it's in lib/ > I can re-confirm that on my Windows setup, pgevent.dll is present in bin/ for PG17 and HEAD and in lib/ for PG16. -- With Regards, Amit Kapila.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
meson: Build pgevent as shared_module rather than shared_library
- 766b0b40aa6a 16.7 landed
- e00c1e249f9b 17.3 landed
- 4ee130c6e03b 18.0 landed