Horton

Re: logicalrep_message_type throws an error

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Euler Taveira <euler@eulerto.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers@lists.postgresql.org
Date: 2023-07-17T02:17:40Z
Lists: pgsql-hackers 
On Sat, Jul 15, 2023 at 7:16 PM Euler Taveira <euler@eulerto.com> wrote:
>
> On Sat, Jul 15, 2023, at 4:27 AM, Amit Kapila wrote:
>
> Do you have something like attached in mind?
>
>
> WFM. I would change the comment that says
>
> This function is called to provide context in the error ...
>
> to
>
> This message provides context in the error ...
>
> because this comment is not at the beginning of the function but *before* the
> message.
>

Sounds reasonable to me. I'll make this modification before pushing
unless there are more comments/suggestions.

-- 
With Regards,
Amit Kapila.

Commits

  1. Fix the display of UNKNOWN message type in apply worker.