Re: a fast bloat measurement tool (was Re: Measuring relation free space)

On Fri, Apr 24, 2015 at 8:04 AM, Abhijit Menon-Sen <ams@2ndquadrant.com>
wrote:
>
> At 2015-04-24 07:22:27 +0530, amit.kapila16@gmail.com wrote:
> >
> > Few minor issues:
> > 1.
> > warning on windows
> >
> > \pgstatbloat.c(193): warning C4715: 'pgstatbloat' : not all control
paths
> > return a value
>
> This is because the function ends with an ereport(ERROR, …). What would
> you suggest here?

For similar code in function (pgstattuple.c->pgstat_relation()), it simply
return 0;

> Just stick a PG_RETURN_NULL() at the end?
>

That should also work.

> > 2.
> > Failed to install pgstattuple--1.3.sql
> >
> > You have to name sql file as pgstattuple--1.3.sql rather
> > than pgstattuple--1.2.sql
>
> How are you applying the patch? It already contains this:
>
>     diff --git a/contrib/pgstattuple/pgstattuple--1.2.sql
b/contrib/pgstattuple/pgstattuple--1.3.sql
>     similarity index 73%
>     rename from contrib/pgstattuple/pgstattuple--1.2.sql
>     rename to contrib/pgstattuple/pgstattuple--1.3.sql
>     index e5fa2f5..93593ee 100644
>     --- a/contrib/pgstattuple/pgstattuple--1.2.sql
>     +++ b/contrib/pgstattuple/pgstattuple--1.3.sql
>
> So it should do the right thing with git apply.
>

I was using patch -p1 ...


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com